lkml.org 
[lkml]   [2016]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC v2c 8/8] fs: xfs: change inode times to use vfs_time data type
    Date
    The VFS inode timestamps are not y2038 safe as they use
    struct timespec. These will be changed to use struct timespec64
    instead and that is y2038 safe.
    But, since the above data type conversion will break the end
    file systems, use timespec64 and conversion functions here to
    access inode times.

    All the timestamps are converted to use struct timespec64 data
    type. And, all the vfs timestamps are converted to timespec64
    at the boundary of vfs.

    Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
    ---
    fs/xfs/xfs_inode.c | 2 +-
    fs/xfs/xfs_iops.c | 2 +-
    fs/xfs/xfs_trans_inode.c | 7 ++++---
    3 files changed, 6 insertions(+), 5 deletions(-)

    diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
    index ceba1a8..ebf76a3 100644
    --- a/fs/xfs/xfs_inode.c
    +++ b/fs/xfs/xfs_inode.c
    @@ -765,7 +765,7 @@ xfs_ialloc(
    xfs_inode_t *ip;
    uint flags;
    int error;
    - struct timespec tv;
    + struct vfs_time tv;

    /*
    * Call the space management code to pick
    diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
    index 76b71a1..7f8a897 100644
    --- a/fs/xfs/xfs_iops.c
    +++ b/fs/xfs/xfs_iops.c
    @@ -973,7 +973,7 @@ xfs_vn_setattr(
    STATIC int
    xfs_vn_update_time(
    struct inode *inode,
    - struct timespec *now,
    + struct vfs_time *now,
    int flags)
    {
    struct xfs_inode *ip = XFS_I(inode);
    diff --git a/fs/xfs/xfs_trans_inode.c b/fs/xfs/xfs_trans_inode.c
    index b97f1df..1242502 100644
    --- a/fs/xfs/xfs_trans_inode.c
    +++ b/fs/xfs/xfs_trans_inode.c
    @@ -68,7 +68,7 @@ xfs_trans_ichgtime(
    int flags)
    {
    struct inode *inode = VFS_I(ip);
    - struct timespec tv;
    + struct vfs_time tv;

    ASSERT(tp);
    ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
    @@ -76,13 +76,14 @@ xfs_trans_ichgtime(
    tv = current_fs_time(inode->i_sb);

    if ((flags & XFS_ICHGTIME_MOD) &&
    - !timespec_equal(&inode->i_mtime, &tv)) {
    + !vfs_time_equal(&inode->i_mtime, &tv)) {
    inode->i_mtime = tv;
    ip->i_d.di_mtime.t_sec = tv.tv_sec;
    ip->i_d.di_mtime.t_nsec = tv.tv_nsec;
    }
    +
    if ((flags & XFS_ICHGTIME_CHG) &&
    - !timespec_equal(&inode->i_ctime, &tv)) {
    + !vfs_time_equal(&inode->i_ctime, &tv)) {
    inode->i_ctime = tv;
    ip->i_d.di_ctime.t_sec = tv.tv_sec;
    ip->i_d.di_ctime.t_nsec = tv.tv_nsec;
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-02-12 11:01    [W:4.110 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site