lkml.org 
[lkml]   [2016]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC v2c 0/8] vfs 64 bit time transition proposal
Date
Introduction

The series is one of the proposals on how to transition VFS timestamps
to use 64 bit time. The credit for the idea goes to Arnd Bergmann and
it’s a mix of approaches 2a and 2b.

Solution

1.Define vfs_time as alias to timespec.
2.Define accessor functions for inode timestamps.
3.Change individual filesystems to use timespec64 timestamps.
Make sure each filesystem will be safe when converted to use
timespec64.
4.Change individual filesystems to use only vfs_time data type
for inode timestamps. Make sure each filesystem will be safe
when converted to use timespec64.
5.Change vfs_time to timespec64.
6.Delete all accessors from individual filesystem and access inode
timestamps directly.

Note that the series only includes patches for steps 1-4.

Variant

We could make the solution similar to 2a and use timespec in the
individual filesystems instead of timespec64.

Concerns

1. It is not clear when vfs_time or accessors should be used.
Even though it is advisable to make the conversions at vfs boundary,
it is not easy to catch the exceptions.
2. Maintenance of the code base before vfs layer is changed is
going to be a little hard as developers might be confused because
of 1.
3. Has the same problem as changing all filesystems to 64 bit:
the switch over to timespec64 has to be done globally in a single,
huge patch for some filesystems.

Deepa Dinamani (8):
vfs: Add vfs_time abstractions
fs: cifs: Change auxdata to struct timespec64 data type
fs: cifs: Change cifs_fattr timestamps data type to timespec64
fs: cifs: Make cnvrtDosUnixTm() y2038 safe
fs: btrfs: Change btrfs_inode.i_otime to vfs_time data type
fs: btrfs: Use vfs timestamp abstraction helper
fs: ceph: Use vfs timestamp abstraction helpers
fs: xfs: change inode times to use vfs_time data type

fs/btrfs/btrfs_inode.h | 2 +-
fs/btrfs/file.c | 7 ++--
fs/btrfs/inode.c | 6 +--
fs/btrfs/ioctl.c | 4 +-
fs/btrfs/root-tree.c | 2 +-
fs/btrfs/transaction.c | 2 +-
fs/ceph/addr.c | 20 ++++++---
fs/ceph/cache.c | 6 +--
fs/ceph/caps.c | 10 ++---
fs/ceph/dir.c | 4 +-
fs/ceph/file.c | 14 +++++--
fs/ceph/inode.c | 91 +++++++++++++++++++++++------------------
fs/ceph/mds_client.c | 9 ++--
fs/ceph/mds_client.h | 2 +-
fs/ceph/snap.c | 6 +--
fs/ceph/super.h | 9 ++--
fs/ceph/xattr.c | 2 +-
fs/cifs/cache.c | 16 +++++---
fs/cifs/cifsencrypt.c | 4 +-
fs/cifs/cifsglob.h | 6 +--
fs/cifs/cifsproto.h | 6 +--
fs/cifs/cifssmb.c | 6 +--
fs/cifs/inode.c | 35 +++++++++-------
fs/cifs/netmisc.c | 16 ++++----
fs/xfs/xfs_inode.c | 2 +-
fs/xfs/xfs_iops.c | 2 +-
fs/xfs/xfs_trans_inode.c | 7 ++--
include/linux/ceph/decode.h | 9 ++--
include/linux/ceph/osd_client.h | 4 +-
include/linux/fs.h | 21 ++++++++++
net/ceph/osd_client.c | 4 +-
31 files changed, 199 insertions(+), 135 deletions(-)

--
1.9.1

\
 
 \ /
  Last update: 2016-02-12 11:01    [W:0.176 / U:1.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site