Messages in this thread | | | From | Anil Gurumurthy <> | Subject | RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() | Date | Thu, 11 Feb 2016 08:42:22 +0000 |
| |
You could remove the __bfa_trc32() routine
Thanks, Acked-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
-----Original Message----- From: Martin K. Petersen [mailto:martin.petersen@oracle.com] Sent: 10 February 2016 22:59 To: Denys Vlasenko <dvlasenk@redhat.com> Cc: James Bottomley <JBottomley@Parallels.com>; Fabian Frederick <fabf@skynet.be>; Anil Gurumurthy <Anil.Gurumurthy@qlogic.com>; Christoph Hellwig <hch@lst.de>; Guenter Roeck <linux@roeck-us.net>; Ben Hutchings <ben@decadent.org.uk>; linux-kernel <linux-kernel@vger.kernel.org>; linux-scsi <linux-scsi@vger.kernel.org> Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()
>>>>> "Denys" == Denys Vlasenko <dvlasenk@redhat.com> writes:
Denys> __bfa_trc32() is very similar, so it is uninlined too. However, Denys> it appears to be unused, therefore this patch ifdefs it out.
Why don't we just drop it?
-- Martin K. Petersen Oracle Linux Engineering
| |