Messages in this thread | | | Date | Thu, 11 Feb 2016 16:58:03 +0100 | Subject | Re: [PATCH 0/3] cpufreq: Replace timers with utilization update callbacks | From | "Rafael J. Wysocki" <> |
| |
On Thu, Feb 11, 2016 at 4:29 PM, Peter Zijlstra <peterz@infradead.org> wrote: > On Thu, Feb 11, 2016 at 01:08:28PM +0100, Rafael J. Wysocki wrote: >> > Not really pretty though. It blows a bit that you require this callback >> > to be periodic (in order to replace a timer). >> >> We need it for now, but that's because of how things work on the cpufreq side. > > Right, maybe stick a big comment on cpufreq_trigger_update() noting its > a big ugly hack and will go away 'soon'.
I will.
>> The last version is here: >> >> https://patchwork.kernel.org/patch/8275271/ >> >> but it has the additional hooks for RT/DL which you seem to be >> thinking are a mistake. > > As long as we make sure everbody knows they're a band-aid and will be > taken out back and shot that should be fine for a little while I > suppose.
Great, thanks!
Yes, I'm treating those as a band-aid for replacement.
Let me update the patch with a comment to explain that.
Thanks, Rafael
| |