lkml.org 
[lkml]   [2016]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 2/2] mips: Differentiate between 32 and 64 bit ELF header
From
Date
On 02/11/2016 01:04 PM, Maciej W. Rozycki wrote:
> On Thu, 11 Feb 2016, Ralf Baechle wrote:
>> Thanks, applied.
>>
>> I'm getting a less spectacular warning from gcc 5.2:
>>
>> CC fs/proc/vmcore.o
>> fs/proc/vmcore.c: In function ‘parse_crash_elf64_headers’:
>> fs/proc/vmcore.c:939:47: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
>
> Yes, the temporaries still need to have their pointed types changed, to
> `Elf32_Ehdr' and `Elf64_Ehdr' respectively, as in the original change.
>
> I had it mentioned in a WIP version of my review (stating that it would
> verify that the correct type is used by the caller), but then deleted that
> part inadvertently, sigh.

Yeah, that part fall through the cracks.

> Daniel, sorry for the extra iteration.

No problem. Just a sec.

cheers,
daniel

\
 
 \ /
  Last update: 2016-02-11 13:21    [W:1.284 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site