lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V4 12/23] x86, ia64, pci: Remove ACPI companion device from platform specific data.
From
Date
On 02/09/2016 06:28 PM, Lorenzo Pieralisi wrote:
> This patch has to be squashed with the previous one otherwise it
> has bisectability issues (ie the previous patch passes the parent
> to the pci_create_root_bus() call so, without this patch applied,
> the companion initialization would fail).
I do not think so. The previous patch passes the parent to the
pci_create_root_bus(), indeed, so pci_create_root_bus() set companion
device before calling pcibios_root_bridge_prepare() (for both cases x86
and ia64). In turn, pcibios_root_bridge_prepare() will do nothing, since
bridge->dev.parent != NULL. After all, pcibios_root_bridge_prepare() is
dead code.
>
> Other than that:
>
> Reviewed-by: Lorenzo Pieralisi<lorenzo.pieralisi@arm.com>
Thanks!

Tomasz

\
 
 \ /
  Last update: 2016-02-10 22:41    [W:0.097 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site