lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mmc: block: return error on failed mmc_blk_get()
From
On 9 February 2016 at 18:34, Olof Johansson <olof@lixom.net> wrote:
> This used to return -EFAULT, but the function above returns -EINVAL on
> the same condition so let's stick to that.
>
> The removal of error return on this path was introduced with b093410c9aef
> ('mmc: block: copy resp[] data on err for MMC_IOC_MULTI_CMD').
>
> Fixes: b093410c9aef ('mmc: block: copy resp[] data on err for MMC_IOC_MULTI_CMD').
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Grant Grundler <grundler@google.com>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
> drivers/mmc/card/block.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 57a5b6d..b3ec4fb 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -655,8 +655,10 @@ static int mmc_blk_ioctl_multi_cmd(struct block_device *bdev,
> }
>
> md = mmc_blk_get(bdev->bd_disk);
> - if (!md)
> + if (!md) {
> + err = -EINVAL;
> goto cmd_err;
> + }
>
> card = md->queue.card;
> if (IS_ERR(card)) {
> --
> 2.1.4
>

\
 
 \ /
  Last update: 2016-02-10 10:01    [W:0.038 / U:4.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site