Messages in this thread | | | Subject | Re: [PATCH] cifs: fix erroneous return value | From | Joe Perches <> | Date | Wed, 10 Feb 2016 09:59:46 -0800 |
| |
On Wed, 2016-02-10 at 12:50 -0500, Anton Protopopov wrote: > The setup_ntlmv2_rsp() function may return positive value ENOMEM instead > of -ENOMEM in case of kmalloc failure.
How have you verified this change is correct?
Have you checked that the callers of this function in fs/cifs/sess.c do the appropriate things with with a negative return value?
The return value is now set into a struct member variable as a positive value,
sess_data->result = rc;
Have you checked all the users of this member variable?
If you have, you should say so in the commit message.
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com> > --- > fs/cifs/cifsencrypt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c > index afa09fc..e682b36 100644 > --- a/fs/cifs/cifsencrypt.c > +++ b/fs/cifs/cifsencrypt.c > @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp) > > ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL); > if (!ses->auth_key.response) { > - rc = ENOMEM; > + rc = -ENOMEM; > ses->auth_key.len = 0; > goto setup_ntlmv2_rsp_ret; > }
| |