Messages in this thread | | | Date | Wed, 10 Feb 2016 16:09:12 +0000 | From | Lee Jones <> | Subject | Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client |
| |
On Tue, 09 Feb 2016, Laxman Dewangan wrote:
> There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no call to i2c_get_clientdata() for rtc_i2c client, > there is no need to store pointer and hence removing the call > to set client data for rtc i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > This is new in this series based on review comment from V1. > > Changes from V2: > - Rephrase description. > - Added reviewed by. > > Changes from V3: > - None, become 5th on series. > > Changes from V4: > None > > Changes from V5: > None > > Changes from V6: > Make this as 4th of series as regmap change applied independently. > > drivers/mfd/max77686.c | 1 - > 1 file changed, 1 deletion(-)
Appart from the subject line being wrong:
Acked-by: Lee Jones <lee.jones@linaro.org>
[...]
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |