lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/5] drm/gma500: fix error path in gma_intel_setup_gmbus()
    From
    On Tue, Feb 9, 2016 at 10:11 PM, Rasmus Villemoes
    <linux@rasmusvillemoes.dk> wrote:
    > The current code fails to call i2c_del_adapter on
    > dev_prev->gmbus[0].adapter, and if the for loop above failed already
    > at i==0, all hell breaks loose when we do the loop body for
    > i = -1,-2,...
    >

    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

    > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    > ---
    > drivers/gpu/drm/gma500/intel_gmbus.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/intel_gmbus.c
    > index 566d330aaeea..e7e22187c539 100644
    > --- a/drivers/gpu/drm/gma500/intel_gmbus.c
    > +++ b/drivers/gpu/drm/gma500/intel_gmbus.c
    > @@ -436,7 +436,7 @@ int gma_intel_setup_gmbus(struct drm_device *dev)
    > return 0;
    >
    > err:
    > - while (--i) {
    > + while (i--) {
    > struct intel_gmbus *bus = &dev_priv->gmbus[i];
    > i2c_del_adapter(&bus->adapter);
    > }
    > --
    > 2.1.4
    >



    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2016-02-10 08:21    [W:4.722 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site