lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: Provide MACRO to declare commonly defined MFD cell attributes

On Tuesday 09 February 2016 07:57 PM, Lee Jones wrote:
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> include/linux/mfd/core.h | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index 27dac3f..dacdc49 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -16,6 +16,38 @@
>
> #include <linux/platform_device.h>
>
> +#define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match) \
> + { \
> + .name = (_name), \
> + .num_resources = ARRAY_SIZE((_res)), \
> + .resources = (_res), \
> + .platform_data = (_pdata), \
> + .pdata_size = ARRAY_SIZE((_pdata)), \
> + .of_compatible = (_compat), \
> + .acpi_match = (_match), \
> + .id = _id, \
> + }
>

Should we add the _res_size and _pdata_size also in argument and use
them instead of ARRA_SIZE and lets client set the size with help of
ARRAY_SIZE based on type of data?

\
 
 \ /
  Last update: 2016-02-10 14:01    [W:0.091 / U:41.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site