lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode
On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote:

SNIP

> + printed += fprintf(fp, "%s\n", buf);
> +
> + if (symbol_conf.use_callchain && he->leaf) {
> + u64 total = hists__total_period(hists);
> +
> + printed += hist_entry_callchain__fprintf(he, total, 0, fp);
> + goto out;
> + }
> +
> +out:
> + return printed;
> +}
> +
> static int hist_entry__fprintf(struct hist_entry *he, size_t size,
> struct hists *hists,
> char *bf, size_t bfsz, FILE *fp)
> @@ -423,6 +488,13 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
> if (size == 0 || size > bfsz)
> size = hpp.size = bfsz;
>
> + if (symbol_conf.report_hierarchy) {

it'd be great for review to have symbol_conf.report_hierarchy already
present, so I could try it early in the patchset like with this change

jirka

\
 
 \ /
  Last update: 2016-02-10 13:41    [W:0.423 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site