lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/23] perf hists: Support filtering in hierarchy mode
On Fri, Feb 05, 2016 at 10:01:45PM +0900, Namhyung Kim wrote:

SNIP

> + /* force to go to sibling in the hierarchy */
> + saved_unfolded = h->unfolded;
> + h->unfolded = false;
> +
> + nd = rb_hierarchy_next(&h->rb_node);
> + h->unfolded = saved_unfolded;
> + }
> + }
> +
> + /* resort output (top-level entries only) */
> + nd = rb_first(&hists->entries);
> + while (nd) {
> + struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node);
> +
> + nd = rb_next(nd);
> + rb_erase(&h->rb_node, &hists->entries);
> +
> + __hists__insert_output_entry(&tmp, h, 0, false);
> + }

what's the purpose of this resort? the only affect I see
is to recalculate callchains

thanks,
jirka

\
 
 \ /
  Last update: 2016-02-10 13:41    [W:0.127 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site