lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] w1: w1_process() is not freezable kthread
On Sun, 7 Feb 2016, GregKH wrote:

> I can't find this patch anywhere in my queue, can you please resend it
> to me with the ack so I can apply it?

Greg, please find it below. Thanks.





From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] w1: w1_process() is not freezable kthread

From: Jiri Kosina <jkosina@suse.cz>

w1_process() calls try_to_freeze(), but the thread doesn't mark itself
freezable through set_freezable(), so the try_to_freeze() call is useless.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/w1/w1.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index c9a7ff6..89a7847 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -1147,7 +1147,6 @@ int w1_process(void *data)
jremain = 1;
}

- try_to_freeze();
__set_current_state(TASK_INTERRUPTIBLE);

/* hold list_mutex until after interruptible to prevent loosing
--
Jiri Kosina
SUSE Labs
\
 
 \ /
  Last update: 2016-02-10 12:01    [W:0.049 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site