lkml.org 
[lkml]   [2016]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine
    Date
    From: Cristian Birsan <cristian.birsan@microchip.com>

    Commit 6b6e97107f12f3a9f7 (USB: musb: fix isochronous TXDMA (take 2)) introduces
    a problem setting the desired channel mode for the Mentor DMA engine.

    There is a case where the pointer of the channel DMA mode is incorrectly
    assigned to a pointer value, when it should be assigned the actual mode value.
    This results in the value of channel->desired_mode not being correct.

    Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
    Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
    ---
    drivers/usb/musb/musb_host.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
    index 3fdc99b..748379e 100644
    --- a/drivers/usb/musb/musb_host.c
    +++ b/drivers/usb/musb/musb_host.c
    @@ -662,7 +662,7 @@ static int musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
    csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE);
    csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */
    }
    - channel->desired_mode = mode;
    + channel->desired_mode = *mode;
    musb_writew(epio, MUSB_TXCSR, csr);

    return 0;
    --
    1.7.9.5
    \
     
     \ /
      Last update: 2016-02-02 01:41    [W:8.789 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site