lkml.org 
[lkml]   [2016]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/7] blk-flush: run the queue when inserting blk-mq flush
    From
    Date
    On 12/08/2016 09:13 PM, Jens Axboe wrote:
    > Currently we pass in to run the queue async, but don't flag the
    > queue to be run. We don't need to run it async here, but we should
    > run it. So fixup the parameters.
    >
    > Signed-off-by: Jens Axboe <axboe@fb.com>
    > ---
    > block/blk-flush.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/block/blk-flush.c b/block/blk-flush.c
    > index 1bdbb3d3e5f5..27a42dab5a36 100644
    > --- a/block/blk-flush.c
    > +++ b/block/blk-flush.c
    > @@ -426,7 +426,7 @@ void blk_insert_flush(struct request *rq)
    > if ((policy & REQ_FSEQ_DATA) &&
    > !(policy & (REQ_FSEQ_PREFLUSH | REQ_FSEQ_POSTFLUSH))) {
    > if (q->mq_ops) {
    > - blk_mq_insert_request(rq, false, false, true);
    > + blk_mq_insert_request(rq, false, true, false);
    > } else
    > list_add_tail(&rq->queuelist, &q->queue_head);
    > return;
    >
    Reviewed-by: Hannes Reinecke <hare@suse.com>

    Cheers,

    Hannes
    --
    Dr. Hannes Reinecke Teamlead Storage & Networking
    hare@suse.de +49 911 74053 688
    SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
    GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
    HRB 21284 (AG Nürnberg)

    \
     
     \ /
      Last update: 2016-12-09 07:46    [W:2.304 / U:0.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site