Messages in this thread | | | Subject | Re: [PATCH] md: Combine two kmalloc() calls into one in sb_equal() | From | Bernd Schubert <> | Date | Fri, 9 Dec 2016 20:09:58 +0100 |
| |
On 09.12.2016 19:30, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 9 Dec 2016 19:09:13 +0100 > > The function "kmalloc" was called in one case by the function "sb_equal" > without checking immediately if it failed.
Err, your patch actually *replaces* the check. So where did you get the idea from that it is not checked immediately?
[...]
> - tmp1 = kmalloc(sizeof(*tmp1),GFP_KERNEL); > - tmp2 = kmalloc(sizeof(*tmp2),GFP_KERNEL); > - > - if (!tmp1 || !tmp2) { > - ret = 0; > - goto abort; > - }
This is not immediately?
Bernd
| |