lkml.org 
[lkml]   [2016]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 10/45] rtnl: fix the loop index update error in rtnl_dump_ifinfo()
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>


    [ Upstream commit 3f0ae05d6fea0ed5b19efdbc9c9f8e02685a3af3 ]

    If the link is filtered out, loop index should also be updated. If not,
    loop index will not be correct.

    Fixes: dc599f76c22b0 ("net: Add support for filtering link dump by master device and kind")
    Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
    Acked-by: David Ahern <dsa@cumulusnetworks.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/core/rtnetlink.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/core/rtnetlink.c
    +++ b/net/core/rtnetlink.c
    @@ -1578,7 +1578,7 @@ static int rtnl_dump_ifinfo(struct sk_bu
    head = &net->dev_index_head[h];
    hlist_for_each_entry(dev, head, index_hlist) {
    if (link_dump_filtered(dev, master_idx, kind_ops))
    - continue;
    + goto cont;
    if (idx < s_idx)
    goto cont;
    err = rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK,

    \
     
     \ /
      Last update: 2016-12-09 17:32    [W:2.675 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site