Messages in this thread | | | Subject | Re: staging: comedi: usbduxsigma: Split a condition check in usbduxsigma_alloc_usb_buffers() | From | Ian Abbott <> | Date | Thu, 8 Dec 2016 18:12:53 +0000 |
| |
On 08/12/16 15:46, SF Markus Elfring wrote: >>> * Reduce memory allocation sizes for two function calls. > > Is this implementation detail worth for further considerations?
I assume you are referring to the allocation of devpriv->ai_urbs and devpriv->ao_urbs? Your patch does not reduce their sizes; `urb` and `*devpriv->ai_urbs` have the same type `struct urb *`. Having said that, `sizeof(*devpriv->ai_urbs)` is cleaner code than `sizeof(urb)` in this case.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |