Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 5/8] efi: Get the secure boot status [ver #5] | Date | Thu, 08 Dec 2016 17:31:13 +0000 |
| |
Lukas Wunner <lukas@wunner.de> wrote:
> > +out_efi_err: > > + pr_efi_err(sys_table_arg, "Could not determine UEFI Secure Boot status.\n"); > > + if (status == EFI_NOT_FOUND) > > + return efi_secureboot_mode_disabled; > > + return efi_secureboot_mode_unknown; > > +} > > In the out_efi_err path, the if-statement needs to come before the > pr_efi_err() call. Otherwise it would be a change of behaviour for > ARM to what we have now.
As I understand it, if the BIOS is an EFI BIOS, these variables must exist - in which case I would argue that the pr_efi_err-statement should be before the if-statement.
David
| |