lkml.org 
[lkml]   [2016]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/18] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32
    On Tue, Dec 06, 2016 at 11:55:08AM +0530, Yury Norov wrote:
    > On Mon, Dec 05, 2016 at 04:34:23PM +0000, Catalin Marinas wrote:
    > > On Fri, Oct 21, 2016 at 11:33:15PM +0300, Yury Norov wrote:
    > > > New aarch32 ptrace syscall handler is introduced to avoid run-time
    > > > detection of the task type.
    > >
    > > What's wrong with the run-time detection? If it's just to avoid a
    > > negligible overhead, I would rather keep the code simpler by avoiding
    > > duplicating the generic compat_sys_ptrace().
    >
    > Nothing wrong. This is how Arnd asked me to do. You already asked this
    > question: http://lkml.iu.edu/hypermail/linux/kernel/1604.3/00930.html

    Hmm, I completely forgot about this ;). There is still an advantage to
    doing run-time checking if we avoid touching core code (less acks to
    gather and less code duplication).

    Let's see what Arnd says but the initial patch looked simpler.

    --
    Catalin

    \
     
     \ /
      Last update: 2016-12-07 18:00    [W:2.478 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site