Messages in this thread | | | Date | Wed, 7 Dec 2016 10:02:19 +0100 | From | Greg KH <> | Subject | Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers |
| |
On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote: > From: Jeremy Kerr <jk@ozlabs.org> > > Add some helpers for the crc checks for the slave configuration table. > This works 4-bits-at-a-time, using a simple table approach. > > We will need this in the FSI core code, as well as any master > implementations that need to calculate CRCs in software. > > Signed-off-by: Jeremy Kerr <jk@ozlabs.org> > Signed-off-by: Chris Bostic <cbostic@us.ibm.com> > --- > drivers/fsi/fsi-core.c | 21 +++++++++++++++++++++ > drivers/fsi/fsi-master.h | 21 +++++++++++++++++++++ > 2 files changed, 42 insertions(+)
Why not just create lib/crc4.c with these functions, like the other crc functions in the kernel? Don't bury these in some random driver subsystem please.
thanks,
greg k-h
| |