Messages in this thread | | | From | Masahiro Yamada <> | Date | Wed, 7 Dec 2016 10:34:53 +0900 | Subject | Re: [PATCH] clk: uniphier: Fix build with gcc-4.4. |
| |
Hi Stephen,
2016-12-07 8:16 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>: > On 12/03, Masahiro Yamada wrote: >> Hi Vinson, >> >> 2016-12-03 9:37 GMT+09:00 Vinson Lee <vlee@freedesktop.org>: >> > gcc-4.4 has issues with anonymous unions in initializers. >> > >> > CC drivers/clk/uniphier/clk-uniphier-sys.o >> > drivers/clk/uniphier/clk-uniphier-sys.c:45: error: unknown field ‘factor’ specified in initializer >> > >> > Fixes: 1574d5722636 ("clk: uniphier: remove unneeded member name for union") >> > Signed-off-by: Vinson Lee <vlee@freedesktop.org> >> >> >> This driver has COMPILE_TEST option, but kbuild test robot >> did not mention about this. >> >> >> >> This is a bad way of fixing, I think. >> (what if a new member is inserted before the union in the future?) >> >> Rather, please revert the bad commit. >> > > Reverting on top of clk-next will cause build failures though. > Can you resend the patch series without this first patch please? > I'll apply them then. > > I'll go drop all three patches and wreck Andrew's merge of this > patch to -mm.
I dropped the first one and v3 (for the last two) is on the ML now.
Thanks a lot for taking care of this!
-- Best Regards Masahiro Yamada
| |