Messages in this thread | | | From | Rafał Miłecki <> | Date | Tue, 6 Dec 2016 18:31:52 +0100 | Subject | Re: [PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT |
| |
On 6 December 2016 at 18:28, Ray Jui <ray.jui@broadcom.com> wrote: > On 12/6/2016 9:17 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> There are 3 separated controllers, one per USB /standard/. With PHY >> drivers in place they can be simply supported with generic drivers. >> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >> --- >> arch/arm/boot/dts/bcm5301x.dtsi | 33 ++++++++++++++++++++++++++++++++- >> 1 file changed, 32 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi >> index f09a2bb..bfc98d19 100644 >> --- a/arch/arm/boot/dts/bcm5301x.dtsi >> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >> @@ -248,8 +248,26 @@ >> >> #address-cells = <1>; >> #size-cells = <1>; >> + ranges; >> >> - phys = <&usb2_phy>; >> + interrupt-parent = <&gic>; >> + >> + ohci: ohci@21000 { >> + #usb-cells = <0>; >> + >> + compatible = "generic-ohci"; >> + reg = <0x00022000 0x1000>; > > Your label ohci@21000 does not match the 'reg' at 0x22000. > >> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>; >> + }; >> + >> + ehci: ehci@22000 { >> + #usb-cells = <0>; >> + >> + compatible = "generic-ehci"; >> + reg = <0x00021000 0x1000>; > > Looks like you got the label of ohci and ehci reversed?
Nice catch, thanks! I'll fix it in V2 (just let me wait a day to see if there will be other comments).
-- Rafał
| |