lkml.org 
[lkml]   [2016]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 03/10] drm/virtio: fix lock context imbalance
    When virtio_gpu_free_vbufs exits due to list empty, it does not
    drop the free_vbufs lock that it took.
    list empty is not expected to happen anyway, but it can't hurt to fix
    this and drop the lock.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---
    drivers/gpu/drm/virtio/virtgpu_vq.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
    index 5a0f8a7..2f0c2f9 100644
    --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
    +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
    @@ -109,8 +109,10 @@ void virtio_gpu_free_vbufs(struct virtio_gpu_device *vgdev)

    spin_lock(&vgdev->free_vbufs_lock);
    for (i = 0; i < count; i++) {
    - if (WARN_ON(list_empty(&vgdev->free_vbufs)))
    + if (WARN_ON(list_empty(&vgdev->free_vbufs))) {
    + spin_unlock(&vgdev->free_vbufs_lock);
    return;
    + }
    vbuf = list_first_entry(&vgdev->free_vbufs,
    struct virtio_gpu_vbuffer, list);
    list_del(&vbuf->list);
    --
    MST
    \
     
     \ /
      Last update: 2016-12-06 16:43    [W:4.810 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site