Messages in this thread | | | Subject | Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay | From | Sylwester Nawrocki <> | Date | Tue, 06 Dec 2016 12:15:17 +0100 |
| |
(resending, hopefully now it reaches the mailing lists)
On 12/05/2016 11:09 AM, Javi Merino wrote:
> Each time the overlay is applied, its of_node pointer will be > different. We are not interested in matching the pointer, what we > want to match is that the path is the one we are expecting. Change to > use of_node_cmp() so that we continue matching after the overlay has > been removed and reapplied. > > Signed-off-by: Javi Merino <javi.merino@kernel.org>
Thanks, there is clearly a bug in current code as it assumed static representation of DT in the kernel.
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> --- > drivers/media/v4l2-core/v4l2-async.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index 5bada20..d33a17c 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -42,7 +42,8 @@ static bool match_devname(struct v4l2_subdev *sd, > > static bool match_of(struct v4l2_subdev *sd, struct v4l2_async_subdev *asd) > { > - return sd->of_node == asd->match.of.node; > + return !of_node_cmp(of_node_full_name(sd->of_node), > + of_node_full_name(asd->match.of.node)); > }
| |