lkml.org 
[lkml]   [2016]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] PCI: designware: add host_init() error handling
From
Date
Às 11:51 AM de 12/2/2016, Srinivas Kandagatla escreveu:
>
>
> On 02/12/16 10:32, Joao Pinto wrote:
>>
>> Hi Srinivas,
>>
>> Às 11:51 AM de 12/1/2016, Srinivas Kandagatla escreveu:
>>> drivers/pci/host/pci-dra7xx.c | 4 +++-
>>> drivers/pci/host/pci-exynos.c | 4 +++-
>>> drivers/pci/host/pci-imx6.c | 4 +++-
>>> drivers/pci/host/pci-keystone.c | 4 +++-
>>> drivers/pci/host/pci-layerscape.c | 12 ++++++++----
>>> drivers/pci/host/pcie-armada8k.c | 4 +++-
>>> drivers/pci/host/pcie-designware-plat.c | 4 +++-
>>> drivers/pci/host/pcie-designware.c | 4 +++-
>>> drivers/pci/host/pcie-designware.h | 2 +-
>>> drivers/pci/host/pcie-qcom.c | 6 ++++--
>>> drivers/pci/host/pcie-spear13xx.c | 4 +++-
>>> 11 files changed, 37 insertions(+), 15 deletions(-)
>>>
>>
>> Thanks for the patch!
>>
>> In my opinion your idea is good but only qcom driver is able to detect failure
>> in the specific host init routine, all others have a 'return 0' even if
>> something not well init. I would recomend that we take this issue a bit further
>> and add the error checking to all specific pci drivers in order to make them as
>> robust as qcom'.
> I totally agree with you, I can give this a go in next version.

Sure, but I think it would be better to finish now since we are on top of the
task. I can help you if you need.

Thanks Joao

>
> Thanks,
> srini
>
>>
>> Thanks,
>> Joao
>>

\
 
 \ /
  Last update: 2016-12-05 11:35    [W:0.050 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site