Messages in this thread | | | Date | Mon, 5 Dec 2016 10:08:13 +0100 | From | Benjamin Tissoires <> | Subject | Re: [PATCH 1/2] devicetree: i2c-hid: Add regulator support |
| |
On Dec 02 2016 or thereabouts, Brian Norris wrote: > From: Caesar Wang <wxt@rock-chips.com> > > Document a "vdd-supply" and an initialization delay. Can be used for > powering on/off a HID. > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: linux-input@vger.kernel.org > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > v2: > * add compatible property for wacom, per Rob's request > * name the regulator property specifically (VDD) > > v3: > * remove wacom property, per Benjamin's request > * add delay property > > v4: no change > --- > Documentation/devicetree/bindings/input/hid-over-i2c.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > index 488edcb264c4..1ea290167652 100644 > --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt > +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > @@ -17,6 +17,11 @@ Required properties: > - interrupt-parent: the phandle for the interrupt controller > - interrupts: interrupt line > > +Optional properties: > +- vdd-supply: phandle of the regulator that provides the supply voltage. > +- init-delay-ms: time required by the device after power-on before it is ready > + for communication.
Nitpick: maybe we should say that the power-on applies to the vdd-supply parameter, not the SET_POWER HID command. I am just worried people will misuse this parameter.
Otherwise, Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> + > Example: > > i2c-hid-dev@2c { > -- > 2.8.0.rc3.226.g39d4020 >
| |