Messages in this thread | | | Date | Sun, 4 Dec 2016 09:17:34 +0200 | From | Leon Romanovsky <> | Subject | Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value |
| |
On Sun, Dec 04, 2016 at 02:45:38PM +0800, Pan Bian wrote: > From: Pan Bian <bianpan2016@163.com> > > If uhw->inlen is non-zero, the value of variable err is 0 if the copy > succeeds. Then, if kzalloc() or kmalloc() returns a NULL pointer, it > will return 0 to the callers. As a result, the callers cannot detect the > errors. This patch fixes the bug, assign "-ENOMEM" to err before the > NULL pointer checks, and remove the initialization of err at the > beginning. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189031 > Signed-off-by: Pan Bian <bianpan2016@163.com>
Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com> [unhandled content-type:application/pgp-signature] | |