lkml.org 
[lkml]   [2016]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/1] net: wireless: intersil: fix improper return value
    Date
    Function orinoco_ioctl_commit() returns 0 (indicates success) when the
    call to orinoco_lock() fails. Thus, the return value is inconsistent with
    the execution status. It may be better to return "-EBUSY" when the call
    to orinoco_lock() fails.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188671

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    ---
    drivers/net/wireless/intersil/orinoco/wext.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/intersil/orinoco/wext.c b/drivers/net/wireless/intersil/orinoco/wext.c
    index 1d4dae4..fee57ea 100644
    --- a/drivers/net/wireless/intersil/orinoco/wext.c
    +++ b/drivers/net/wireless/intersil/orinoco/wext.c
    @@ -1314,7 +1314,7 @@ static int orinoco_ioctl_commit(struct net_device *dev,
    return 0;

    if (orinoco_lock(priv, &flags) != 0)
    - return err;
    + return -EBUSY;

    err = orinoco_commit(priv);

    --
    1.9.1

    \
     
     \ /
      Last update: 2016-12-03 11:23    [W:2.729 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site