Messages in this thread | | | From | "Kweh, Hock Leong" <> | Subject | RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe | Date | Wed, 28 Dec 2016 05:49:18 +0000 |
| |
> -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Wednesday, December 28, 2016 12:34 AM > To: Kweh, Hock Leong <hock.leong.kweh@intel.com> > Cc: Joao.Pinto@synopsys.com; peppe.cavallaro@st.com; > seraphin.bonnaffe@st.com; f.fainelli@gmail.com; > alexandre.torgue@gmail.com; manabian@gmail.com; niklas.cassel@axis.com; > johan@kernel.org; pavel@ucw.cz; Ong, Boon Leong > <boon.leong.ong@intel.com>; Voon, Weifeng <weifeng.voon@intel.com>; > lars.persson@axis.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and > stmmac_dvr_probe > > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com> > Date: Tue, 27 Dec 2016 22:42:36 +0800 > > > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com> > > You are not the author of this change, do not take credit for it. > > You have copied Florian's patch character by character, therefore > he is the author. > > You also didn't CC: the netdev mailing list properly.
Hi David & Florian,
Just to clarify that I do not copy exactly from Florian. I have changed it to have proper handling on mdio unregister while netdev_register() failed as showed below:
return 0;
-error_mdio_register: - unregister_netdev(ndev); error_netdev_register: + stmmac_mdio_unregister(ndev); +error_mdio_register: netif_napi_del(&priv->napi);
Vs
+ + return ret;
error_mdio_register: - unregister_netdev(ndev); -error_netdev_register: netif_napi_del(&priv->napi);
Just to point it out here, so that Florian could aware if he/she submit this fix to the mailing list.
Thanks & Regards, Wilson
| |