lkml.org 
[lkml]   [2016]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/15] hyperv: use standard bitops
From
Date


On 21/12/2016 14:23, Roman Kagan wrote:
> On Wed, Dec 21, 2016 at 01:00:44PM +0100, Olaf Hering wrote:
>> On Tue, Dec 20, Roman Kagan wrote:
>>
>> Reverting commit 22356585712d ("staging: hv: use sync_bitops when
>> interacting with the hypervisor") is save because .......
>>
>>> - sync_set_bit(channel->monitor_bit,
>>> + set_bit(channel->monitor_bit,
>
> It isn't indeed. I didn't realize there was a UP case where it made a
> difference, and failed to locate the commit where it changed.
>
> I'll drop this part, thanks.

Perhaps the sync_bitops should be renamed to virt_bitops. This would
match virt_* memory barriers and would make their usage much more obvious.

Paolo

\
 
 \ /
  Last update: 2016-12-22 13:35    [W:1.115 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site