Messages in this thread | | | Date | Wed, 21 Dec 2016 15:14:46 -0800 | From | Stephen Boyd <> | Subject | Re: [PATCH 02/11] clk: bcm2835: Register the DSI0/DSI1 pixel clocks. |
| |
On 12/14, Eric Anholt wrote: > > /* the gates */ > > @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_device *pdev) > if (IS_ERR(cprman->regs)) > return PTR_ERR(cprman->regs); > > - cprman->osc_name = of_clk_get_parent_name(dev->of_node, 0); > - if (!cprman->osc_name) > + for (i = 0; i < ARRAY_SIZE(cprman_parent_names); i++) { > + cprman->real_parent_names[i] = > + of_clk_get_parent_name(dev->of_node, i); > + }
Can we use of_clk_parent_fill() here? Or do we need to support holes in the parent array? If it's the latter please add a comment so we don't mistakenly change this later.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |