lkml.org 
[lkml]   [2016]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same
From
Date
Am 16.12.2016 um 18:07 schrieb Radim Krčmář:
> 2016-12-16 17:53+0100, Paolo Bonzini:
>> On 16/12/2016 17:41, David Hildenbrand wrote:
>>>
>>> Just to verify:
>>>
>>> The GET_APIC_DEST_FIELD(mda) == APIC_BROADCAST is still correct in
>>> kvm_apic_broadcast() ?
>>
>> No, it seems wrong.
>
> Definitely, sending v4 of this patch.
> I'll also add broadcast address check into kvm-unit-tests ...
> ---8<---
> Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
> to xAPIC VCPUs and vice-versa. Make slow path behave like fast path,
> which never distinguished that.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> v4: fix xAPIC broadcast address detection [David]
> ---
> arch/x86/kvm/lapic.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>

Looks good to me.

Reviewed-by: David Hildenbrand <david@redhat.com>

--

David

\
 
 \ /
  Last update: 2016-12-19 15:58    [W:1.062 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site