Messages in this thread | | | Date | Sun, 18 Dec 2016 18:23:35 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock |
| |
Hi!
> > - e1efa87241272104d6a12c8b9fcdc4f62634d447 > > Yep, a sync of the dma descriptors before the hardware gets ownership of the tx tail > idx is missing in the stmmac, too.
Thanks for the hint. Actually, the driver uses smp_wmb() which is completely crazy, and probably misses rmb() in clean_tx, too. Anyway, I did not notice there are dma_ variants, too... we clearly need them.
Thanks and best regards, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |