lkml.org 
[lkml]   [2016]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] printk: Remove no longer used second struct cont
    From
    Date


    On 12/15/2016 07:50 PM, Linus Torvalds wrote:
    > On Thu, Dec 15, 2016 at 5:37 PM, Sergey Senozhatsky
    > <sergey.senozhatsky.work@gmail.com> wrote:
    >> basically I'm talking about a bunch of 80-cols fixups.
    > Please don't.
    >
    > Nobody uses a vt100 terminal any more. The 80-column wrapping is
    > excessive, and makes things like "grep" not work as well.
    >
    > No, we still don't want excessively long lines, but that's generally
    > mainly because
    >
    > (a) we don't want to have excessively _complicated_ lines
    >
    > (b) we don't want to have excessively deep indentation (so if line
    > length is due to 4+ levels of indentation, that's usually the primary
    > problem).
    >
    > (c) email quoting gets iffier and uglier, so short lines always are
    > preferred if possible
    >
    > but in general, aside from those concerns, a long legible line is
    > generally preferred over just adding line breaks for the very
    > _occasional_ line.
    >
    > At the 100-column mark you almost have to break, because at that point
    > people may start to be actually limited by their displays, but 80
    > columns generally isn't it.
    >
    > In fact, I thought we already upped the check-patch limit to 100?
    checkpatch.pl line 50
    my $max_line_length = 80;

    Not changed as of yet.
    >
    > Linus

    \
     
     \ /
      Last update: 2016-12-18 20:30    [W:3.185 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site