Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 16 Dec 2016 11:42:08 -0800 | Subject | Re: [GIT PULL] KVM fixes for 4.10 merge window |
| |
On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini <pbonzini@redhat.com> wrote: > > git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
This piece-of-shit branch has obviously never been even compile-tested:
arch/x86/kernel/kvm.c: In function ‘__kvm_vcpu_is_preempted’: arch/x86/kernel/kvm.c:596:14: error: ‘struct kvm_steal_time’ has no member named ‘preempted’
where commit b94c3698b4b0 ("Revert "x86/kvm: Support the vCPU preemption check"") removed the "preempted" field from struct kvm_steal_time, but you left this in place:
__visible bool __kvm_vcpu_is_preempted(int cpu) { struct kvm_steal_time *src = &per_cpu(steal_time, cpu);
return !!src->preempted; }
And no, that is not a merge artifact in my tree (although that function did come in from Ingo). That compile failure comes from your very own branch.
Am I upset? You bet I am. Get your act together. You can't just randomly revert things without checking the end result.
Linus
| |