lkml.org 
[lkml]   [2016]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] media: omap3isp change to devm for resources
Date
Hi Shuah,

Thank you for the patch.

Sakari has submitted a similar patch as part of his kref series. Please use it
as a base point and rework it if you want to get it merged separately. I've
reviewed the patch and left quite a few comments that need to be addressed.

On Thursday 15 Dec 2016 12:40:08 Shuah Khan wrote:
> Using devm resources that have external dependencies such as a dev
> for a file handler could result in devm resources getting released
> durin unbind while an application has the file open holding pointer
> to the devm resource. This results in use-after-free errors when the
> application exits.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/platform/omap3isp/isp.c | 71 ++++++++++++++++--------
> drivers/media/platform/omap3isp/ispccp2.c | 10 +++-
> drivers/media/platform/omap3isp/isph3a_aewb.c | 21 +++++---
> drivers/media/platform/omap3isp/isph3a_af.c | 21 +++++---
> drivers/media/platform/omap3isp/isphist.c | 5 +-
> 5 files changed, 92 insertions(+), 36 deletions(-)

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2016-12-15 23:35    [W:0.240 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site