Messages in this thread | | | From | "Jason A. Donenfeld" <> | Date | Thu, 15 Dec 2016 19:51:13 +0100 | Subject | Re: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long |
| |
Hi David,
On Thu, Dec 15, 2016 at 11:14 AM, David Laight <David.Laight@aculab.com> wrote: > From: Behalf Of Jason A. Donenfeld >> Sent: 14 December 2016 18:46 > ... >> + ret = *chaining = siphash24((u8 *)&combined, offsetof(typeof(combined), end), > > If you make the first argument 'const void *' you won't need the cast > on every call. > > I'd also suggest making the key u64[2].
I'll do both. Thanks for the suggestion.
Jason
| |