Messages in this thread | | | Subject | Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap | From | arvind Yadav <> | Date | Thu, 15 Dec 2016 00:35:13 +0530 |
| |
Hi,
As per your suggestion, I have change the subject.
Thanks
On Thursday 15 December 2016 12:24 AM, Florian Fainelli wrote: > On 12/14/2016 10:39 AM, arvind Yadav wrote: >> Hi David, >> >> I have gave my comment. >> >> Thanks >> Arvind >> >> On Wednesday 14 December 2016 11:44 PM, David Daney wrote: >>> On 12/14/2016 10:06 AM, arvind Yadav wrote: >>>> Yes, I have seen this error. We have a device with very less memory. >>>> Basically it's OMAP2 board. We have to port Android L on this. >>>> It's has 3.10 kernel version. In this device, we were getting Page >>>> allocation failure. >>> This makes absolutely no sense to me. OCTEON is a mips64 SoC with a >>> ton of memory where ioremap can never fail, and it doesn't run >>> Android, and you are talking about OMAP2. >> -I just gave as example where i have seen ioremap issue. >> Please don't relate. I know, Now it will not fail. ioremap will through >> NULL on failure. We should catch this error. Even other driver of MIPS >> soc is having same check. It's just check which will not impact any >> functionality or performance of this driver. It will avoid NULL pointer >> error. We know, if function is returning any error. we should catch. > Your patch subject should also be changed to insert spaces between > semicolon, so this would be: > > net: ethernet: cavium: octeon: octeon_mgmt:
| |