Messages in this thread | | | Date | Wed, 14 Dec 2016 17:41:33 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2 1/3] power: supply: bq24735-charger: simplify register update to stop charging |
| |
Hi,
On Wed, Dec 14, 2016 at 12:56:43AM +0100, Peter Rosin wrote: > Providing value bits outside of the mask is pointless. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > drivers/power/supply/bq24735-charger.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c > index eb7783b42e0a..1d5c9206e0ed 100644 > --- a/drivers/power/supply/bq24735-charger.c > +++ b/drivers/power/supply/bq24735-charger.c > @@ -111,8 +111,7 @@ static inline int bq24735_enable_charging(struct bq24735 *charger) > return 0; > > return bq24735_update_word(charger->client, BQ24735_CHG_OPT, > - BQ24735_CHG_OPT_CHARGE_DISABLE, > - ~BQ24735_CHG_OPT_CHARGE_DISABLE); > + BQ24735_CHG_OPT_CHARGE_DISABLE, 0); > } > > static inline int bq24735_disable_charging(struct bq24735 *charger)
Thanks for your patch. We are currently in the merge window and your patch will appear in linux-next once 4.10-rc1 has been tagged by Linus Torvalds.
Until then I queued it into this branch:
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next-next
-- Sebastian [unhandled content-type:application/pgp-signature] | |