lkml.org 
[lkml]   [2016]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler
    From
    Date
    On 12/14/2016 01:09 AM, Bart Van Assche wrote:
    > On 12/08/2016 09:13 PM, Jens Axboe wrote:
    >> +static inline bool dd_rq_is_shadow(struct request *rq)
    >> +{
    >> + return rq->rq_flags & RQF_ALLOCED;
    >> +}
    >
    > Hello Jens,
    >
    > Something minor: because req_flags_t has been defined using __bitwise
    > (typedef __u32 __bitwise req_flags_t) sparse complains for the above
    > function about converting req_flags_t into bool. How about changing the
    > body of that function into "return (rq->rq_flags & RQF_ALLOCED) != 0" to
    > keep sparse happy?

    Sure, I can fold in that change.

    --
    Jens Axboe

    \
     
     \ /
      Last update: 2016-12-14 16:04    [W:4.517 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site