Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 13 Dec 2016 15:01:12 +0100 | Subject | Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers |
| |
Hi Petr,
On Tue, Dec 13, 2016 at 2:52 PM, Petr Mladek <pmladek@suse.com> wrote: > From 5b5a8f7ff4f2d5c33316e600a29d45314ac47a16 Mon Sep 17 00:00:00 2001 > From: Petr Mladek <pmladek@suse.com> > Date: Tue, 13 Dec 2016 13:12:56 +0100 > Subject: [PATCH] btrfs: Better handle btrfs_printk() defaults > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The commit 262c5e86fec7cfd ("printk/btrfs: handle more message headers") > triggers: > > warning: ‘ratelimit’ may be used uninitialized in this function > > with gcc (4.1.2) and probably many other versions. The code actually > is correct but a bit twisted. Let's make it more straightforward > and set the default values at the beginning. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Petr Mladek <pmladek@suse.com>
Thanks, that fixes the warning.
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |