lkml.org 
[lkml]   [2016]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Remaining crypto API regressions with CONFIG_VMAP_STACK
From
Date
On 12/12/2016 12:34 PM, Andy Lutomirski wrote:

<...snip...>

>
> I have a patch to make these depend on !VMAP_STACK.
>
>> drivers/crypto/ccp/ccp-crypto-aes-cmac.c:105,119,142
>> drivers/crypto/ccp/ccp-crypto-sha.c:95,109,124
>> drivers/crypto/ccp/ccp-crypto-aes-xts.c:162
>> drivers/crypto/ccp/ccp-crypto-aes.c:94
>
> According to Herbert, these are fine. I'm personally less convinced
> since I'm very confused as to what "async" means in the crypto code,
> but I'm going to leave these alone.

I went back through the code, and AFAICT every argument to sg_init_one() in
the above-cited files is a buffer that is part of the request context. Which
is allocated by the crypto framework, and therefore will never be on the
stack.
Right?

I don't (as yet) see a need for any patch to these. Someone correct me
if I'm
missing something.

<...snip...>

--
This is my day job. Follow me at:
IG/Twitter/Facebook: @grhookphoto
IG/Twitter/Facebook: @grhphotographer

\
 
 \ /
  Last update: 2016-12-12 23:19    [W:0.123 / U:1.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site