lkml.org 
[lkml]   [2016]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] ASoC: samsung: Remove tests of member address
    Date

    Hi,

    On Saturday, December 10, 2016 11:51:11 AM Krzysztof Kozlowski wrote:
    > The driver was checking for non-NULL address of struct's members:
    > - s3c_audio_pdata->type (union),
    > - s3c_audio_pdata->type.i2s (embedded struct).
    >
    > This is pointless as these will be always non-NULL. The 's3c_audio_pdata'
    > is always initialized in static memory so it will be zeroed.
    > Additionally the 'type' member was an union with only one member.
    >
    > It is safe to reorganize the structures to get rid of useless union and
    > checks for addresses to fix the coccinelle warning:
    > >> sound/soc/samsung/i2s.c:1270:2-4: ERROR: test of a variable/field address
    >
    > Reported-by: kbuild test robot <fengguang.wu@intel.com>
    > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

    Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

    Best regards,
    --
    Bartlomiej Zolnierkiewicz
    Samsung R&D Institute Poland
    Samsung Electronics

    \
     
     \ /
      Last update: 2016-12-12 14:36    [W:4.457 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site