lkml.org 
[lkml]   [2016]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[V1] rtc:rtc-vr41xx :- Retunr error is not correct in rtc_probe
Date
Here, rtc_probe is returning EBUSY at any error case.
It should return ENOMEM insted of EBUSY.

-EBUSY A resource you need is not avaialable.

-ENOMEM This is used to signify lack of memory resources.

-ENODEV This is used when no device is available.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/rtc/rtc-vr41xx.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c
index e1b86bb..e666d8e 100644
--- a/drivers/rtc/rtc-vr41xx.c
+++ b/drivers/rtc/rtc-vr41xx.c
@@ -292,21 +292,21 @@ static int rtc_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
- return -EBUSY;
+ return -ENOMEM;

rtc1_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
if (!rtc1_base)
- return -EBUSY;
+ return -ENOMEM;

res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (!res) {
- retval = -EBUSY;
+ retval = -ENOMEM;
goto err_rtc1_iounmap;
}

rtc2_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
if (!rtc2_base) {
- retval = -EBUSY;
+ retval = -ENOMEM;
goto err_rtc1_iounmap;
}

@@ -342,7 +342,7 @@ static int rtc_probe(struct platform_device *pdev)

pie_irq = platform_get_irq(pdev, 1);
if (pie_irq <= 0) {
- retval = -EBUSY;
+ retval = -ENODEV;
goto err_iounmap_all;
}

--
2.7.4
\
 
 \ /
  Last update: 2016-12-11 17:42    [W:0.033 / U:3.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site