lkml.org 
[lkml]   [2016]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iio: adc: max1027: allocate DMA-safe buffer
From
Date
On 09/12/16 10:24, Marcus Folkesson wrote:
> The buffer needs to be DMA-safe when used with spi_read()
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Please read the documentation in include/linux/gfp.h about GFP_DMA.

Specifically:
220 * GFP_DMA exists for historical reasons and should be avoided where possible.
221 * The flags indicates that the caller requires that the lowest zone be
222 * used (ZONE_DMA or 16M on x86-64). Ideally, this would be removed but
223 * it would require careful auditing as some users really require it and
224 * others use the flag to avoid lowmem reserves in ZONE_DMA and treat the
225 * lowest zone as a type of emergency reserve.

Seems unlikely this applies! This caught me by surprise as I didn't even know
that flag existed - hence I went digging.

Jonathan
> ---
> drivers/iio/adc/max1027.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
> index 712fbd2b1f16..ff1f1f15a873 100644
> --- a/drivers/iio/adc/max1027.c
> +++ b/drivers/iio/adc/max1027.c
> @@ -435,7 +435,7 @@ static int max1027_probe(struct spi_device *spi)
>
> st->buffer = devm_kmalloc(&indio_dev->dev,
> indio_dev->num_channels * 2,
> - GFP_KERNEL);
> + GFP_KERNEL | GFP_DMA);
> if (st->buffer == NULL) {
> dev_err(&indio_dev->dev, "Can't allocate buffer\n");
> return -ENOMEM;
>

\
 
 \ /
  Last update: 2016-12-10 18:37    [W:0.044 / U:24.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site