[lkml]   [2016]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 15/23] arm: use kconfig fragments for ARCH_PXA defconfigs (part 1)
Bartlomiej Zolnierkiewicz <> writes:

> Replace [lpd270,lubbock,mainstone,pxa255-idp]_defconfig-s with
> a Makefile target using merge_config.
> The patch was verified with doing:
> $ make [lpd270,...]_defconfig
> $ make savedefconfig
> and comparing resulting defconfig files (before/after the patch).
> Cc: Daniel Mack <>
> Cc: Haojian Zhuang <>
> Cc: Robert Jarzmik <>
> Cc: Cyril Bur <>
> Signed-off-by: Bartlomiej Zolnierkiewicz <>

Hi Bartolomiej,

It's a bit hard to judge without any context for me, especially I'm receiving
patches 11 to 21 but not the others. I suppose the advantage of defconfig
fragments was already discussed somewhere, could you point me to that please ?

One small thing that could be improved is the "pxa_basic*" names.

I think pxa_basic1 is "pxa_refboards" or something like that, as these are the
initial reference designs as far as I know from Intel and validation vehicles
rather that form factors.

In the same way, pxa_basic2 is rather "pxa_sharpsl" as these are sharp designs.

And pxa_basic3 looks like Motorola platforms, so "pxa_motorola" perhaps ?

I noticed imote2.config ended up based on pxa_basic3, while I would have
expected it to be based on pxa_basic1 as it looks like a reference board to me



 \ /
  Last update: 2016-12-10 10:48    [W:0.105 / U:2.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site