Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 1 Dec 2016 09:47:22 +0100 | Subject | Re: [PATCH] pinctrl: sh-pfc: r8a7791: Add ADI pinconf support |
| |
Hi Jacopo,
On Tue, Nov 29, 2016 at 10:11 AM, Jacopo Mondi <jacopo@jmondi.org> wrote: > Add pin configuration support for Gyro-ADC, named ADI on r8a7791 SoC. > > The Gyro-ADC supports three different configurations: > a single ADC (adi and adi_b groups), 2 ADCs selectable through a single > channel select signal (adi_chsel1 and adi_chsel1_b groups), up to 4 ADCs > through 2 channel select signals (adi_chsel2 and adi_chsel2_b groups) > and up to 8 ADCs through 3 channel select signals (adi_chsel3 and > adi_chsel3_b groups) > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> +static const char * const adi_groups[] = { > + "adi",
As the group names below have a suffix ("_chselX"), I think it would be good to have a suffix in this group name, too. Usually we have splits like "data" and "ctrl", but in this case, the group covers both data and control signals. "adi_common"? "adi_base"? "adi_spi" (but it's only SPI in mode 2/3)?
I'm out of inspiration...
> + "adi_chsel1", > + "adi_chsel2", > + "adi_chsel3",
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |