lkml.org 
[lkml]   [2016]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] x86/kbuild: enable modversions for symbols exported from asm
    On Thu, Dec 1, 2016 at 5:58 AM, Arnd Bergmann <arnd@arndb.de> wrote:
    >
    > WARNING: EXPORT symbol "mcount" [arch/x86/entry/built-in.ko] version generation failed, symbol will not be versioned.
    > WARNING: EXPORT symbol "mcount" [arch/x86/built-in.ko] version generation failed, symbol will not be versioned.
    > WARNING: EXPORT symbol "cmpxchg8b_emu" [vmlinux] version generation failed, symbol will not be versioned.
    > WARNING: EXPORT symbol "empty_zero_page" [vmlinux] version generation failed, symbol will not be versioned.
    > WARNING: EXPORT symbol "mcount" [vmlinux] version generation failed, symbol will not be versioned.
    > WARNING: EXPORT symbol "cmpxchg8b_emu" [vmlinux] version generation failed, symbol will not be versioned.
    > WARNING: EXPORT symbol "empty_zero_page" [vmlinux] version generation failed, symbol will not be versioned.
    > WARNING: EXPORT symbol "mcount" [vmlinux] version generation failed, symbol will not be versioned.
    >
    > Out of 12 randconfig builds that had CONFIG_MODVERSIONS enabled, all 12
    > had this problem, though not always with all the symbols.

    Well, the good news is that pretty fundamentally, if it's just the asm
    symbls, those really don't have ABI's that change (or if they change,
    it's such a fundamental change that everything else will likely have
    changed too and we don't need to worry about one asm symbol crc - the
    change will be caught by other symbols).

    So I think the whole "we don't really care" approach should work fine.
    The "let's make every symbol always be versioned" may just be too much
    pain for no real gain.

    Linus

    \
     
     \ /
      Last update: 2016-12-01 19:26    [W:3.600 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site